From 4c8ff4a7ec4c667fd70f68e39366e79929020149 Mon Sep 17 00:00:00 2001 From: Rico van Zelst Date: Wed, 26 Feb 2025 21:16:50 +0100 Subject: [PATCH 1/9] chore: remove ads from various views Cleaned up the code by removing ad placeholders from multiple view files. --- resources/views/assets/index.blade.php | 3 --- resources/views/components/ads/horizontal-banner.blade.php | 0 resources/views/components/champions/list_all.blade.php | 3 --- resources/views/components/emotes/list_all.blade.php | 5 ----- resources/views/components/home/features.blade.php | 3 --- resources/views/components/icons/list_all.blade.php | 6 ------ resources/views/components/icons/view_grid.blade.php | 7 ------- resources/views/components/sales/current_sales.blade.php | 2 -- resources/views/components/skins/paginatedlist.blade.php | 7 ------- resources/views/posts/show.blade.php | 2 -- 10 files changed, 38 deletions(-) create mode 100644 resources/views/components/ads/horizontal-banner.blade.php diff --git a/resources/views/assets/index.blade.php b/resources/views/assets/index.blade.php index 40117fa..81ebdc0 100644 --- a/resources/views/assets/index.blade.php +++ b/resources/views/assets/index.blade.php @@ -19,9 +19,6 @@ class="text-lg font-bold text-center text-transparent uppercase bg-gradient-to-bl from-orange-300 to-orange-500 bg-clip-text"> LoL Icons & Emotes - -
Heimerdinger Emote diff --git a/resources/views/components/ads/horizontal-banner.blade.php b/resources/views/components/ads/horizontal-banner.blade.php new file mode 100644 index 0000000..e69de29 diff --git a/resources/views/components/champions/list_all.blade.php b/resources/views/components/champions/list_all.blade.php index 19e2c3d..5c22b87 100644 --- a/resources/views/components/champions/list_all.blade.php +++ b/resources/views/components/champions/list_all.blade.php @@ -11,9 +11,6 @@ Champions - -
diff --git a/resources/views/components/emotes/list_all.blade.php b/resources/views/components/emotes/list_all.blade.php index e998671..0c9a869 100644 --- a/resources/views/components/emotes/list_all.blade.php +++ b/resources/views/components/emotes/list_all.blade.php @@ -9,11 +9,6 @@ -
- -
-
diff --git a/resources/views/components/home/features.blade.php b/resources/views/components/home/features.blade.php index 75aa476..280458d 100644 --- a/resources/views/components/home/features.blade.php +++ b/resources/views/components/home/features.blade.php @@ -84,9 +84,6 @@ information about the game.

-
-
diff --git a/resources/views/components/icons/list_all.blade.php b/resources/views/components/icons/list_all.blade.php index 97fb0c3..751b65a 100644 --- a/resources/views/components/icons/list_all.blade.php +++ b/resources/views/components/icons/list_all.blade.php @@ -7,12 +7,6 @@ class="text-3xl font-bold text-center text-transparent uppercase sm:text-4xl bg-gradient-to-bl from-orange-300 to-orange-500 bg-clip-text"> Summoner Icons - -
- -
-
diff --git a/resources/views/components/icons/view_grid.blade.php b/resources/views/components/icons/view_grid.blade.php index 2c0a793..4d2ee15 100644 --- a/resources/views/components/icons/view_grid.blade.php +++ b/resources/views/components/icons/view_grid.blade.php @@ -102,13 +102,6 @@
- -
- -
-
diff --git a/resources/views/components/sales/current_sales.blade.php b/resources/views/components/sales/current_sales.blade.php index 5c39ed6..44cd3f1 100644 --- a/resources/views/components/sales/current_sales.blade.php +++ b/resources/views/components/sales/current_sales.blade.php @@ -46,8 +46,6 @@ @endforeach - diff --git a/resources/views/components/skins/paginatedlist.blade.php b/resources/views/components/skins/paginatedlist.blade.php index 7f45c86..979f9e5 100644 --- a/resources/views/components/skins/paginatedlist.blade.php +++ b/resources/views/components/skins/paginatedlist.blade.php @@ -8,13 +8,6 @@ Champion Skins - - @fragment('skin-list')
diff --git a/resources/views/posts/show.blade.php b/resources/views/posts/show.blade.php index 20b1a0d..4242798 100644 --- a/resources/views/posts/show.blade.php +++ b/resources/views/posts/show.blade.php @@ -40,8 +40,6 @@

“{{ $post->description }}”

-

{{ $post->contents }}

From 45d6cad605aca6590a06ee7dfbef4d9ffa24fe89 Mon Sep 17 00:00:00 2001 From: Rico van Zelst Date: Wed, 26 Feb 2025 21:16:57 +0100 Subject: [PATCH 2/9] feat: enhance ad container styles Added new styles for the ad container to improve layout and appearance. - Set overflow to hidden - Defined width and max-width as 100% - Added background color and border radius for ads --- resources/css/app.css | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/resources/css/app.css b/resources/css/app.css index 8e67e45..ac9163e 100644 --- a/resources/css/app.css +++ b/resources/css/app.css @@ -153,3 +153,14 @@ ins.adsbygoogle[data-ad-status="unfilled"] { display: none !important; } + +.ad-container { + overflow: hidden; + width: 100%; + max-width: 100%; +} + +.ad-container ins.adsbygoogle { + background-color: rgba(0, 0, 0, 0.02); + border-radius: 4px; +} From 76d468d1daa1883d45ae7c07d82c43fff920dd12 Mon Sep 17 00:00:00 2001 From: Rico van Zelst Date: Wed, 26 Feb 2025 22:24:05 +0100 Subject: [PATCH 3/9] feat: add AdSense configuration file - Introduced a new config file for AdSense settings. - Added client ID and ad slot identifiers for various placements. --- config/ads.php | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 config/ads.php diff --git a/config/ads.php b/config/ads.php new file mode 100644 index 0000000..b086a9f --- /dev/null +++ b/config/ads.php @@ -0,0 +1,22 @@ + 'ca-pub-4505764048662657', + + 'slots' => [ + 'horizontal_banner' => '9840151408', + 'vertical_banner' => '9117294343', + 'in_article' => '7169787855', + 'rectangle' => '1917461172', + 'common' => '4128691547' + ] +]; From 45cb08c4d9ac9d2f319045a85e32682f95ab5a38 Mon Sep 17 00:00:00 2001 From: Rico van Zelst Date: Wed, 26 Feb 2025 22:25:14 +0100 Subject: [PATCH 4/9] refactor: remove ad scripts from views Cleaned up multiple view files by removing Google AdSense script inclusions. --- resources/views/assets/index.blade.php | 11 ----------- resources/views/champions/index.blade.php | 5 ----- resources/views/emotes/index.blade.php | 11 ----------- resources/views/home.blade.php | 11 ----------- resources/views/icons/index.blade.php | 11 ----------- resources/views/icons/show.blade.php | 10 ---------- resources/views/posts/show.blade.php | 14 ++------------ resources/views/sales/index.blade.php | 11 ----------- resources/views/skins/index.blade.php | 11 ----------- 9 files changed, 2 insertions(+), 93 deletions(-) diff --git a/resources/views/assets/index.blade.php b/resources/views/assets/index.blade.php index 81ebdc0..84fb7f3 100644 --- a/resources/views/assets/index.blade.php +++ b/resources/views/assets/index.blade.php @@ -5,11 +5,6 @@ 'Explore game assets on Heimerdinger.LoL. Find detailed information on all icons and emotes available in League of Legends!') - @push('top_scripts') - - @endpush - @section('content')

- (adsbygoogle = window.adsbygoogle || []).push({}); - -@endpush diff --git a/resources/views/champions/index.blade.php b/resources/views/champions/index.blade.php index 717705a..7025e16 100644 --- a/resources/views/champions/index.blade.php +++ b/resources/views/champions/index.blade.php @@ -7,8 +7,6 @@ @push('top_scripts') @vite('resources/js/lane-filter.js') - @endpush @section('content') @@ -17,7 +15,4 @@ @push('bottom_scripts') @include('popper::assets') - @endpush diff --git a/resources/views/emotes/index.blade.php b/resources/views/emotes/index.blade.php index 611d7a8..bbca850 100644 --- a/resources/views/emotes/index.blade.php +++ b/resources/views/emotes/index.blade.php @@ -4,17 +4,6 @@ @section('description', 'Explore all LoL Emotes on Heimerdinger.LoL. Find detailed information on popular emotes such as Dab Pengu, Bee Mad, Little Camper, Super Shy, PENGUMODE and more!') - - @push('top_scripts') - - @endpush @section('content') @endsection - -@push('bottom_scripts') - -@endpush diff --git a/resources/views/home.blade.php b/resources/views/home.blade.php index b832666..32126eb 100644 --- a/resources/views/home.blade.php +++ b/resources/views/home.blade.php @@ -5,11 +5,6 @@ 'Explore League of Legends champions, skins, and game assets on Heimerdinger. Your ultimate source for in-depth information on LoL gaming. Dive in now!') - @push('top_scripts') - - @endpush - @section('content') @@ -18,9 +13,3 @@ @endif @endsection - -@push('bottom_scripts') - -@endpush diff --git a/resources/views/icons/index.blade.php b/resources/views/icons/index.blade.php index c749d03..9e06083 100644 --- a/resources/views/icons/index.blade.php +++ b/resources/views/icons/index.blade.php @@ -5,17 +5,6 @@ 'Explore all LoL icons on Heimerdinger.LoL. Find detailed information on popular summoner icons such as Qiyana Champie 2, Omen of the Cursed Revenant, Lil\' Sprout, Dominion Retirement, Winterblessed Hwei and more!') - @push('top_scripts') - - @endpush - @section('content') @endsection - -@push('bottom_scripts') - -@endpush diff --git a/resources/views/icons/show.blade.php b/resources/views/icons/show.blade.php index c1fff39..9b7985f 100644 --- a/resources/views/icons/show.blade.php +++ b/resources/views/icons/show.blade.php @@ -3,16 +3,6 @@ @section('title', $icon->title . ' • Heimerdinger') @section('description', 'Heimerdinger.LoL: ' . $icon->title . ' details showing all the information about the icon released in ' . $icon->release_year . '. ' . substr($icon->description, 0, 64) . '...') - @push('top_scripts') - - @endpush @section('content') @endsection - -@push('bottom_scripts') - -@endpush diff --git a/resources/views/posts/show.blade.php b/resources/views/posts/show.blade.php index 4242798..39e4731 100644 --- a/resources/views/posts/show.blade.php +++ b/resources/views/posts/show.blade.php @@ -14,11 +14,6 @@ @endpush -@push('top_scripts') - -@endpush - @section('content') Back @@ -40,20 +35,15 @@

“{{ $post->description }}”

+

{{ $post->contents }}

+

Tagged with: {{ isset($post->tags) ? implode(', ', $post->tags) : 'League of Legends' }}

-

@endsection - -@push('bottom_scripts') - -@endpush diff --git a/resources/views/sales/index.blade.php b/resources/views/sales/index.blade.php index 8dab9d6..605d86f 100644 --- a/resources/views/sales/index.blade.php +++ b/resources/views/sales/index.blade.php @@ -5,18 +5,7 @@ 'Explore the current LoL Sale on Heimerdinger.LoL. Find detailed information on what champions and skins are currently on sale and grab a good deal!') - @push('top_scripts') - - @endpush - @section('content') @endsection - -@push('bottom_scripts') - -@endpush \ No newline at end of file diff --git a/resources/views/skins/index.blade.php b/resources/views/skins/index.blade.php index 471737d..e05f598 100644 --- a/resources/views/skins/index.blade.php +++ b/resources/views/skins/index.blade.php @@ -5,17 +5,6 @@ 'Explore all champion skins on Heimerdinger.LoL. Find detailed information on popular skins such as Dark Cosmic Jhin, HEARTSTEEL Ezreal, PROJECT: Vayne and more!') - @push('top_scripts') - - @endpush - @section('content') @endsection - -@push('bottom_scripts') - -@endpush From 22fbead9f4b038525f265dd5844f81975b849d38 Mon Sep 17 00:00:00 2001 From: Rico van Zelst Date: Wed, 26 Feb 2025 22:25:26 +0100 Subject: [PATCH 5/9] feat: add new ad components for various placements --- resources/views/components/ads/common.blade.php | 7 +++++++ .../views/components/ads/horizontal-banner.blade.php | 8 ++++++++ resources/views/components/ads/in-article.blade.php | 7 +++++++ resources/views/components/ads/vertical-banner.blade.php | 8 ++++++++ 4 files changed, 30 insertions(+) create mode 100644 resources/views/components/ads/common.blade.php create mode 100644 resources/views/components/ads/in-article.blade.php create mode 100644 resources/views/components/ads/vertical-banner.blade.php diff --git a/resources/views/components/ads/common.blade.php b/resources/views/components/ads/common.blade.php new file mode 100644 index 0000000..3701c72 --- /dev/null +++ b/resources/views/components/ads/common.blade.php @@ -0,0 +1,7 @@ +
+ + +
diff --git a/resources/views/components/ads/horizontal-banner.blade.php b/resources/views/components/ads/horizontal-banner.blade.php index e69de29..b2781b9 100644 --- a/resources/views/components/ads/horizontal-banner.blade.php +++ b/resources/views/components/ads/horizontal-banner.blade.php @@ -0,0 +1,8 @@ +
+ + +
diff --git a/resources/views/components/ads/in-article.blade.php b/resources/views/components/ads/in-article.blade.php new file mode 100644 index 0000000..1a6ee0d --- /dev/null +++ b/resources/views/components/ads/in-article.blade.php @@ -0,0 +1,7 @@ +
+ + +
diff --git a/resources/views/components/ads/vertical-banner.blade.php b/resources/views/components/ads/vertical-banner.blade.php new file mode 100644 index 0000000..4ccb0ca --- /dev/null +++ b/resources/views/components/ads/vertical-banner.blade.php @@ -0,0 +1,8 @@ +
+ + +
From 8338384df9ba17ca8201fca347e05755450be541 Mon Sep 17 00:00:00 2001 From: Rico van Zelst Date: Wed, 26 Feb 2025 22:25:31 +0100 Subject: [PATCH 6/9] feat: add Google AdSense integration - Included Google AdSense script for ads. - Added common ad component to the layout. --- resources/views/layouts/app.blade.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/resources/views/layouts/app.blade.php b/resources/views/layouts/app.blade.php index 7ce1eac..b58a076 100644 --- a/resources/views/layouts/app.blade.php +++ b/resources/views/layouts/app.blade.php @@ -52,6 +52,10 @@ @vite(['resources/css/app.css', 'resources/js/app.js']) + + + @stack('top_scripts') @@ -59,6 +63,7 @@ @yield('content') + @stack('bottom_scripts') From b8d3c74c195099c50dc1fa3afe84b270ebfd0563 Mon Sep 17 00:00:00 2001 From: Rico van Zelst Date: Wed, 26 Feb 2025 22:25:45 +0100 Subject: [PATCH 7/9] feat: add ad banners to various components - Included horizontal ad banners in champions, home features, and skins sections. - Added vertical ad banners in emotes and icons lists for better visibility. - Adjusted layout for improved spacing around new ads. --- resources/views/components/champions/grid_info.blade.php | 6 +++--- resources/views/components/champions/list_all.blade.php | 4 ++++ resources/views/components/emotes/list_all.blade.php | 5 +++++ resources/views/components/home/features.blade.php | 3 +++ resources/views/components/icons/list_all.blade.php | 4 ++++ resources/views/components/skins/paginatedlist.blade.php | 4 ++++ 6 files changed, 23 insertions(+), 3 deletions(-) diff --git a/resources/views/components/champions/grid_info.blade.php b/resources/views/components/champions/grid_info.blade.php index 14b8220..d7c71dd 100644 --- a/resources/views/components/champions/grid_info.blade.php +++ b/resources/views/components/champions/grid_info.blade.php @@ -37,7 +37,8 @@ Popular Positions: @if (isset($champion->lanes) && isset($champion->lanes->roles)) @foreach ($champion->lanes->roles as $lane) - {{ $lane }} @svg(getRoleIconSvg($lane), 'w-5 h-5 inline-block') + {{ $lane }} + @svg(getRoleIconSvg($lane), 'w-5 h-5 inline-block') @if (!$loop->last) - @endif @@ -150,6 +151,7 @@

{{ $champion->name }} Lore

+

{{ $champion->lore }} @@ -161,8 +163,6 @@ @push('top_scripts') @vite('resources/js/lane-filter.js') - @endpush @push('bottom_scripts') @include('popper::assets') diff --git a/resources/views/components/champions/list_all.blade.php b/resources/views/components/champions/list_all.blade.php index 5c22b87..6ffba52 100644 --- a/resources/views/components/champions/list_all.blade.php +++ b/resources/views/components/champions/list_all.blade.php @@ -15,6 +15,10 @@

+
+ +
+
@foreach ($champions as $key => $champion) diff --git a/resources/views/components/emotes/list_all.blade.php b/resources/views/components/emotes/list_all.blade.php index 0c9a869..dfa1ecc 100644 --- a/resources/views/components/emotes/list_all.blade.php +++ b/resources/views/components/emotes/list_all.blade.php @@ -10,6 +10,11 @@ diff --git a/resources/views/components/icons/list_all.blade.php b/resources/views/components/icons/list_all.blade.php index 751b65a..d0f98a8 100644 --- a/resources/views/components/icons/list_all.blade.php +++ b/resources/views/components/icons/list_all.blade.php @@ -9,6 +9,10 @@
+ +
@foreach ($icons as $key => $icon) diff --git a/resources/views/components/skins/paginatedlist.blade.php b/resources/views/components/skins/paginatedlist.blade.php index 979f9e5..8760f35 100644 --- a/resources/views/components/skins/paginatedlist.blade.php +++ b/resources/views/components/skins/paginatedlist.blade.php @@ -8,6 +8,10 @@ Champion Skins +
+ +
+ @fragment('skin-list')
From c5094aa91a8defd998c305710e1578923f3cf69f Mon Sep 17 00:00:00 2001 From: rico-vz <107053109+rico-vz@users.noreply.github.com> Date: Wed, 26 Feb 2025 21:26:56 +0000 Subject: [PATCH 8/9] Dusting --- config/ads.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/ads.php b/config/ads.php index b086a9f..a5f0eef 100644 --- a/config/ads.php +++ b/config/ads.php @@ -17,6 +17,6 @@ return [ 'vertical_banner' => '9117294343', 'in_article' => '7169787855', 'rectangle' => '1917461172', - 'common' => '4128691547' - ] + 'common' => '4128691547', + ], ]; From a172e757ab316cd1a2f289c207b61e4291369e71 Mon Sep 17 00:00:00 2001 From: rico-vz <107053109+rico-vz@users.noreply.github.com> Date: Wed, 26 Feb 2025 21:26:57 +0000 Subject: [PATCH 9/9] Ignore Dusting commit in git blame --- .git-blame-ignore-revs | 1 + 1 file changed, 1 insertion(+) diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs index 675019f..1431028 100644 --- a/.git-blame-ignore-revs +++ b/.git-blame-ignore-revs @@ -8,3 +8,4 @@ a1713c2f67dc8fcb83b8a54013b74859ff93f076 016a0c75837e666dcc6d04ccbf109ab47618f3dc fb5b8f82813a6ab7122b482db546be37237045ee e3ec9b4abafdeb1eb7550fb7714dfca488be466c +c5094aa91a8defd998c305710e1578923f3cf69f